- Issue created by @andrewlu
- @andrewlu opened merge request.
- 🇨🇦Canada colan Toronto 🇨🇦
@lazzyvn: It looks like this was closed without merging, but this issue is now marked "Fixed". Please explain. Did the fix get in or not? Thanks.
- 🇨🇦Canada colan Toronto 🇨🇦
Okay, thanks. Normally the MR would be "Merged", not "Closed". Not sure why that's happening.
- 🇫🇷France lazzyvn paris
why mr? do you review this?
for me this patch is incorrect. I can accept this, you can see it create phpcs warning. and the translate must do in markup render - 🇨🇦Canada colan Toronto 🇨🇦
I think you're saying that you committed something else because you didn't like the patch. That's fine, but it wasn't clear. Thanks for the explanation!
- 🇨🇦Canada colan Toronto 🇨🇦
It looks like the commit for this is https://git.drupalcode.org/project/datafield/-/commit/48c7d865d41d229985... ? In the future, please:
- Add a link to the commit in the issue (if you're not merging the PR), and
- Reference the issue in the commit message.
Automatically closed - issue fixed for 2 weeks with no activity.