Contrib.social

text_with_summary widget fails if violation lacks value/summary in property path

Open on Drupal.org →
Created on 24 July 2025, 4 months ago

Problem/Motivation

Hello. When adding a violation for a delta of a text field with summary, the form error rendering ends in an exception.

The issue is that the text_textarea_with_summary widget always assumes that the property path contains at least two elements (e.g., 0.value, 0.summary).
But when a violation is added to a field delta directly (e.g., just 0), the widget fails.

There’s no documentation stating that the violation must target a specific sub-property like value or summary.

This is likely a bug, because a related field type - text_long with the text_textarea widget - handles such cases correctly without throwing an error.

I’m aware of the 🌱 [Meta] Deprecate text_with_summary Active issue, which proposes to deprecate the text_with_summary field type and move it to contrib:

2. Move the field type, formatter and widget to a module
3. Deprecate the module and move it to contrib

However, since the text_textarea_with_summary widget is still in use and this is a runtime exception triggered during validation, I believe it should still be fixed.

Backtrace:

The website encountered an unexpected error. Try again later.

TypeError: Drupal\Core\Form\FormState::setError(): Argument #1 ($element) must be of type array, null given, called in /var/www/core/lib/Drupal/Core/Field/WidgetBase.php on line 587 in Drupal\Core\Form\FormState->setError() (line 1157 of core/lib/Drupal/Core/Form/FormState.php).

Drupal\Core\Field\WidgetBase->flagErrors(Object, Object, Array, Object) (Line: 289)
Drupal\Core\Entity\Entity\EntityFormDisplay->flagWidgetsErrorsFromViolations(Object, Array, Object) (Line: 268)
Drupal\Core\Entity\ContentEntityForm->flagViolations(Object, Array, Object) (Line: 214)
Drupal\Core\Entity\ContentEntityForm->validateForm(Array, Object)
call_user_func_array(Array, Array) (Line: 82)
Drupal\Core\Form\FormValidator->executeValidateHandlers(Array, Object) (Line: 275)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object, 'node_page_form') (Line: 118)
Drupal\Core\Form\FormValidator->validateForm('node_page_form', Array, Object) (Line: 585)
Drupal\Core\Form\FormBuilder->processForm('node_page_form', Array, Object) (Line: 321)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 36)
Drupal\Core\Test\StackMiddleware\TestWaitTerminateMiddleware->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 715)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Steps to reproduce

  1. Create a text field with summary enabled.
  2. Add a constraint to the field that triggers a violation on a field delta (e.g., UniqueField) or apply a constraint at the FieldType plugin level.
  3. Trigger validation to surface the error.

Proposed resolution

It appears that the widget is attempting to highlight errors for both value and summary separately.

I propose that when the violation’s property path contains only the delta (no sub-property), the widget should mark the entire widget element as the error target.
This prevents exceptions and allows general validation errors on the whole field to display correctly.

Remaining tasks

  1. Add a test case.
  2. Fix the bug.

User interface changes

None.

Introduced terminology

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

🐛 Bug report
Status

Active

Version

11.2 🔥

Component

text.module

Created by

kksandr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kksandr
  • Merge request !12829Resolve #3537774 "Validation fix" → (Open) created by Unnamed author
  • Merge request !12830Draft: Issue #3537774 by kksandr: add test case → (Closed) created by Unnamed author
  • Pipeline finished with Success
    4 months ago
    Total: 459s
    #555763
  • Pipeline finished with Failed
    4 months ago
    Total: 443s
    #555765
  • Comment 4 months ago →
    kksandr

    I’ve added two branches:

    1. 3537774-validation-test - contains only a test to demonstrate the issue.
    2. 3537774-validation-fix - includes both the test and the fix.
  • Comment 4 months ago →
    kksandr
  • Comment 4 months ago →
    🇺🇸United States smustgrave

    Not 100% which MR to review but MRs need to point to 11.x as the main development branch

  • Comment 4 months ago →
    System Message
  • Comment 4 months ago →
    kksandr

    Alright, I’ve closed the MR that only included the test to avoid any confusion. I’ve also changed the target branch to 11.x.

  • Pipeline finished with Success
    4 months ago
    Total: 518s
    #556045
  • Pipeline finished with Success
    4 months ago
    Total: 913s
    #556046
  • Comment 3 months ago →
    🇺🇸United States smustgrave

    Trying to figure out why the validation changed.

  • Pipeline finished with Success
    3 months ago
    #567546
  • Comment 3 months ago →
    🇺🇸United States smustgrave

    Re-based this a few days ago and forgot

    But rebased so I could run the test-only run

    There was 1 error:
1) Drupal\Tests\text\Functional\TextareaWithSummaryTest::testTextAreaWithSummaryValidation
Exception: Warning: Undefined array key 1
Drupal\text\Plugin\Field\FieldWidget\TextareaWithSummaryWidget->errorElement()() (Line: 104)
/builds/issue/drupal-3537774/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:55
/builds/issue/drupal-3537774/vendor/guzzlehttp/promises/src/Promise.php:209
/builds/issue/drupal-3537774/vendor/guzzlehttp/promises/src/Promise.php:158
/builds/issue/drupal-3537774/vendor/guzzlehttp/promises/src/TaskQueue.php:52
/builds/issue/drupal-3537774/vendor/guzzlehttp/promises/src/Promise.php:251
/builds/issue/drupal-3537774/vendor/guzzlehttp/promises/src/Promise.php:227
/builds/issue/drupal-3537774/vendor/guzzlehttp/promises/src/Promise.php:272
/builds/issue/drupal-3537774/vendor/guzzlehttp/promises/src/Promise.php:229
/builds/issue/drupal-3537774/vendor/guzzlehttp/promises/src/Promise.php:69
/builds/issue/drupal-3537774/vendor/guzzlehttp/guzzle/src/Client.php:189
/builds/issue/drupal-3537774/core/tests/Drupal/Tests/DrupalTestBrowser.php:139
/builds/issue/drupal-3537774/vendor/symfony/browser-kit/AbstractBrowser.php:378
/builds/issue/drupal-3537774/vendor/symfony/browser-kit/AbstractBrowser.php:298
/builds/issue/drupal-3537774/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:718
/builds/issue/drupal-3537774/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:494
/builds/issue/drupal-3537774/vendor/behat/mink/src/Element/NodeElement.php:176
/builds/issue/drupal-3537774/vendor/behat/mink/src/Element/NodeElement.php:186
/builds/issue/drupal-3537774/core/tests/Drupal/Tests/UiHelperTrait.php:112
/builds/issue/drupal-3537774/core/modules/text/tests/src/Functional/TextareaWithSummaryTest.php:89
ERRORS!
Tests: 1, Assertions: 7, Errors: 1.
Exiting with EXIT_CODE=2

    Fix seems fine and feedback addressed just an FYI that this plugin is being targeted to be deprecated 🌱 [Meta] Deprecate text_with_summary Active

  • Issue was unassigned.
  • Status changed to Fixed about 1 month ago
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024