- Issue created by @circuitcipher
- Merge request !9Issue #3537414 by circuitcipher: Make media_gallery compatible with Photoswipe Field Formatter... β (Open) created by Unnamed author
- πΊπΈUnited States circuitcipher
I am currently working on fixing PHPCS errors and hope to push them today.
- πΊπΈUnited States circuitcipher
These changes should be complete at this point. I am just requesting a code review/testing as this is making some sweeping changes and I'm relatively new to the Drupal development space.
- First commit to issue fork.
- ivnish Kazakhstan
I tested this patch manually.
1) The reverse order is broken with pager (reverse works only for current (first?) page)
2) The new pager shows 12 images instead of 9. This can break existing sites.
When you fixed this, I will test upgrade from existing sites
- πΊπΈUnited States circuitcipher
Thank you so much for your timely review! I will work on resolving these issues.
- ivnish Kazakhstan
This issue also has pager issues. If I understand correctly we need to commit another issue first
- πΊπΈUnited States circuitcipher
1) The reverse order is broken with pager (reverse works only for current (first?) page)
2) The new pager shows 12 images instead of 9. This can break existing sites.I have fixed the above issues.
This issue also has pager issues. If I understand correctly we need to commit another issue first
Yes, we should merge β¨ Extra configuration options for the Pager Active first. After those changes are merged, we can implement the necessary items_per_page logic for the pagination logic in this issue.
- ivnish Kazakhstan
I merged MR about pager improvements. Do you need to update this MR ?
- πΊπΈUnited States circuitcipher
I merged MR about pager improvements. Do you need to update this MR ?
Yes, I need to make updates to this MR so that it makes use of the items_per_page parameter. I will submit these changes today.
- πΊπΈUnited States circuitcipher
I merged MR about pager improvements. Do you need to update this MR ?
I have made the changes to support the pager improvements. This is ready for your review.
- πΊπΈUnited States circuitcipher
Ok, I am working on the changes you have requested.