Replace hardcoded Media Photoswipe view mode with configurable formatter

I am currently working on fixing PHPCS errors and hope to push them today.

These changes should be complete at this point. I am just requesting a code review/testing as this is making some sweeping changes and I'm relatively new to the Drupal development space.

I tested this patch manually.

1) The reverse order is broken with pager (reverse works only for current (first?) page)

2) The new pager shows 12 images instead of 9. This can break existing sites.

When you fixed this, I will test upgrade from existing sites

Thank you so much for your timely review! I will work on resolving these issues.

This issue also has pager issues. If I understand correctly we need to commit another issue first

1) The reverse order is broken with pager (reverse works only for current (first?) page)
2) The new pager shows 12 images instead of 9. This can break existing sites.

I have fixed the above issues.

This issue also has pager issues. If I understand correctly we need to commit another issue first

Yes, we should merge ✨ Extra configuration options for the Pager Active first. After those changes are merged, we can implement the necessary items_per_page logic for the pagination logic in this issue.

I merged MR about pager improvements. Do you need to update this MR ?

I merged MR about pager improvements. Do you need to update this MR ?

Yes, I need to make updates to this MR so that it makes use of the items_per_page parameter. I will submit these changes today.

I merged MR about pager improvements. Do you need to update this MR ?

I have made the changes to support the pager improvements. This is ready for your review.

I left a few comments in MR

Ok, I am working on the changes you have requested.

I have completed the requested changes.

I wanted to add a quick explanation as to why I made the changes in commit "9b8e3d90 - Fix(entity): Correct target_bundles format for handler_settings"

I have been working locally on fixing Media Gallery compatibility with Layout Builder and found out that the core logic in Drupal for generating sample content based on bundle types expects that a field's "handler_settings" => "target_bundles" be in a specific format. This fix will be crucial to future enhancements I plan on doing to fix layout builder compatibility.

Merged! Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.