- Issue created by @chike
- πΊπΈUnited States kenrbnsn New Jersey
This is definitely a needed change. The nine images per page is hard-coded and really needs to be a config option.
Getting rid of the navigation arrows when there is no paging renders the gallery useless.
- πΊπΈUnited States circuitcipher
I have implemented these changes and will open up an issue branch / merge request once I have a chance to clean up the implementation and polish the code a bit.
- Merge request !10Resolve #3508977 by circuitcipher "Extra configuration options" adding items per page to galleries β (Merged) created by Unnamed author
- πΊπΈUnited States circuitcipher
We probably want to merge this one before #3537414. This way we have time to implement the changes in #3537414 to support the items_per_page field.
- ivnish Kazakhstan
The new pager shows 12 images instead of 9. This can break existing sites. Let's use 12 by default, but 9 for existing sites
- πΊπΈUnited States circuitcipher
This makes sense to me. I will work on implementing what you have requested.
- ivnish Kazakhstan
I tested it manually with new and existing galleries. No problems found
Do we need every time test SetDefaultItemsPerPageUpdateTest.php ? Looks like one shot test. I tested manually and I think we can remove this test from MR.
- πΊπΈUnited States circuitcipher
Do we need every time test SetDefaultItemsPerPageUpdateTest.php ? Looks like one shot test. I tested manually and I think we can remove this test from MR.
I agree. We can remove it now as this part of the code shouldnβt be updated going forward.
-
ivnish β
committed 0520e548 on 3.0.x authored by
circuitcipher β
Issue #3508977 by circuitcipher, ivnish: Extra configuration options for...
-
ivnish β
committed 0520e548 on 3.0.x authored by
circuitcipher β