When using the module with PHP 8.4 installed several deprecation notices are displayed:
NOTICE: PHP message: PHP Deprecated: Drupal\select_or_other\Plugin\Field\FieldWidget\ReferenceWidget::__construct(): Implicitly marking parameter $entity_type as nullable is deprecated, the explicit nullable type must be used instead in src/Plugin/Field/FieldWidget/ReferenceWidget.php on line 72
NOTICE: PHP message: PHP Deprecated: Drupal\select_or_other\Plugin\Field\FieldWidget\ReferenceWidget::__construct(): Implicitly marking parameter $bundle_info_service as nullable is deprecated, the explicit nullable type must be used instead in src/Plugin/Field/FieldWidget/ReferenceWidget.php on line 72
NOTICE: PHP message: PHP Deprecated: Drupal\select_or_other\Plugin\Field\FieldWidget\ReferenceWidget::__construct(): Implicitly marking parameter $current_user as nullable is deprecated, the explicit nullable type must be used instead in src/Plugin/Field/FieldWidget/ReferenceWidget.php on line 72
NOTICE: PHP message: PHP Deprecated: Drupal\select_or_other\Plugin\Field\FieldWidget\ReferenceWidget::getOptions(): Implicitly marking parameter $entity as nullable is deprecated, the explicit nullable type must be used instead in src/Plugin/Field/FieldWidget/ReferenceWidget.php on line 130
NOTICE: PHP message: PHP Deprecated: Drupal\select_or_other\Plugin\Field\FieldWidget\WidgetBase::getOptions(): Implicitly marking parameter $entity as nullable is deprecated, the explicit nullable type must be used instead in select_or_other/src/Plugin/Field/FieldWidget/WidgetBase.php on line 207
NOTICE: PHP message: PHP Deprecated: Drupal\select_or_other\Plugin\Field\FieldWidget\ListWidget::getOptions(): Implicitly marking parameter $entity as nullable is deprecated, the explicit nullable type must be used instead in select_or_other/src/Plugin/Field/FieldWidget/ListWidget.php on line 107
Active
4.2
Code
@instrafusion in your MR, you are changing the signature of the constructor, that's why the tests are failing. I have changed it, but I was not able to push to your MR, as you created a branch with colon.
@ivnish tests are green now.