- Issue created by @abramm
- ๐บ๐ฆUkraine abramm Lutsk
abramm โ changed the visibility of the branch 3535811-drupal-11-support to hidden.
- ๐บ๐ฆUkraine abramm Lutsk
abramm โ changed the visibility of the branch 3535811-drupal-11-support to active.
- ๐ฎ๐ณIndia vinodhini.e chennai
vinodhini.e โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia vinodhini.e chennai
Hi, Installed this module in Drupal 11.2.2.
Encountered a Twig deprecation error related to the use of the spaceless filter (Since Twig 3.12: Twig Filter "spaceless" is deprecated).
Updated the Twig template file to remove the deprecated spaceless filter and replaced it with a compatible structure.
Submitted a Merge Request with the fix.
The module is now working as expected and is compatible with Drupal 11. Thanks. - ๐บ๐ฆUkraine abramm Lutsk
Hi @vinodhini.e,
Please avoid hijacking other people's MRs; it may be confusing.
I can see that you've reverted some of my changes. Can you please explain this? - ๐ฎ๐ณIndia vinodhini.e chennai
@abramm,
Thank you for your feedback.
My intention was not to hijack your merge request, but to address the Twig deprecation issue that I encountered while testing the module on Drupal 11.2.2. I made minimal changes limited only to the Twig template file only.
Specifically, I removed two lines related to the deprecated spaceless, as it is no longer supported in Drupal 11 / Twig 3.12+.
These changes were committed directly to the current branch: 3535811-drupal-11-support, to help ensure compatibility with Drupal 11. - ๐บ๐ฆUkraine abramm Lutsk
Please check ๐ Twig Filter "spaceless" is deprecated Active .
While the spaceless filter is deprecated in Twig, it's still supported in D11, and there's still no clear decision on whether it would be unsupported in D12 or the replacement would be implemented on Drupal side (since a lot of people depend on it).
Until then, it may remain in custom and contrib code - unless it's absolutely clear that it's not needed and may be safely removed (which is not the case here, as it may break formatting). - ๐ฎ๐ณIndia vinodhini.e chennai
Thank you for the detailed context. I'll review #3477375 before proceeding further.
-
abramm โ
committed 55b6aeba on 8.x-1.x
Issue #3535811 by andriy khomych, chekka.de: Drupal 11 support
-
abramm โ
committed 55b6aeba on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.