- Issue created by @SocialNicheGuru
- π©πͺGermany lrwebks Porta Westfalica
It is always optimal to provide the changes made for this issue in an MR, so I will do that quickly and then take a look.
- @lrwebks opened merge request.
- π©πͺGermany lrwebks Porta Westfalica
The patch provided is not the solution that we want. Simply reverting the new Attributes to old Annotations is a step backward (and backward is always the wrong direction. :)) I'll see if I can reproduce this, since I never ran into that issue before.
- π©πͺGermany lrwebks Porta Westfalica
I currently cannot reproduce the WSOD with the newest development version on the
11.x
branch. @socialnicheguru, if you haven't already, could you also try again using the newest dev version to see if we have (accidentally) fixed it in the meantime? Also (if it isn't too much effort), could you try the installation on 11.x as well, to see if it is a Drupal 10 problem? Thank you in advance! - πΊπΈUnited States SocialNicheGuru
I am on 10.5.x. Could that be the issue? Maybe it is not backward compatible.
- π©πͺGermany lrwebks Porta Westfalica
@socialnicheguru: Okay, tested it on 10.5.1 and getting a similar error after installing
ad_content
with the same cause as your issue. Yes, in Drupal 10.5.x there is no attribute class for content and config entity types yet, only annotations. Meaning: Your patch is technically the correct and only solution to the problem.However, I really am against removing the new attributes in favor of this issue. @anybody, what do you think? We are now faced with the decision of removing progress or removing backward compatibility... What is the best step here in your option?
- π©πͺGermany Anybody Porta Westfalica
@lrwebks and @socialnicheguru as 11.x is still in alpha, I'd vote for removing Drupal 10 compatibility in the module and all submodules and start with 11.x. Sooner or later we'll all land there and that's what alpha is for.
- π©πͺGermany lrwebks Porta Westfalica
@anybody: +1 for that from me! So should I remove the versions from the
info.yml
in here, or should we close this as outdated? - π©πͺGermany Anybody Porta Westfalica
@lrwebks please use the separate branch: https://git.drupalcode.org/issue/ad-3535692/-/tree/3535692-remove-d10-co...
That's always a good idea to keep other peoples work and makes a lot of sense for such cases where the approach is totally different.BTW. then 11.x module version also makes more sense... :D
- π©πͺGermany Anybody Porta Westfalica
@socialnicheguru if you desperately need 10.x compatibility, you could create a separate issue and change compatibility issues there, I'd be open to use the 10.x branch for a limited copy of 11.x that works with Drupal 10!