The Drupal\ad_content\Entity\AdContentType class does not correspond to an entity type. in Drupal\Core\Entity\EntityTypeRepository->getEntityTypeFromClass()

It is always optimal to provide the changes made for this issue in an MR, so I will do that quickly and then take a look.

The patch provided is not the solution that we want. Simply reverting the new Attributes to old Annotations is a step backward (and backward is always the wrong direction. :)) I'll see if I can reproduce this, since I never ran into that issue before.

I currently cannot reproduce the WSOD with the newest development version on the 11.x branch. @socialnicheguru, if you haven't already, could you also try again using the newest dev version to see if we have (accidentally) fixed it in the meantime? Also (if it isn't too much effort), could you try the installation on 11.x as well, to see if it is a Drupal 10 problem? Thank you in advance!

I am on 10.5.x. Could that be the issue? Maybe it is not backward compatible.

@socialnicheguru: Okay, tested it on 10.5.1 and getting a similar error after installing ad_content with the same cause as your issue. Yes, in Drupal 10.5.x there is no attribute class for content and config entity types yet, only annotations. Meaning: Your patch is technically the correct and only solution to the problem.

However, I really am against removing the new attributes in favor of this issue. @anybody, what do you think? We are now faced with the decision of removing progress or removing backward compatibility... What is the best step here in your option?

@lrwebks and @socialnicheguru as 11.x is still in alpha, I'd vote for removing Drupal 10 compatibility in the module and all submodules and start with 11.x. Sooner or later we'll all land there and that's what alpha is for.

@anybody: +1 for that from me! So should I remove the versions from the info.yml in here, or should we close this as outdated?

@lrwebks please use the separate branch: https://git.drupalcode.org/issue/ad-3535692/-/tree/3535692-remove-d10-co...
That's always a good idea to keep other peoples work and makes a lot of sense for such cases where the approach is totally different.

BTW. then 11.x module version also makes more sense... :D

@socialnicheguru if you desperately need 10.x compatibility, you could create a separate issue and change compatibility issues there, I'd be open to use the 10.x branch for a limited copy of 11.x that works with Drupal 10!

Ad 10x branch would make sense to support Drupal 10 and allow the Ad 11.x branch to focus on Drupal 11. (Personally I wish all modules did that; It would make it very easy to understand the numbering).

Could you make the 10.x branch an official release? Would make it easier to work with.

All D10 versions are now removed from the info.ymls!

Thanks @lrwebks, let's merge this into 11.x

@socialnicheguru:

Could you make the 10.x branch an official release?

I think we should leave it with 10.x as dev version, which we could show on the module page. 10.x isn't really supported and worked on any more, so making it official would give a wrong picture.
Could you give 10.x a try and tell if anything major needs to be fixed there?

@socialnicheguru for D10 simply use 4.x please. I just looked into https://git.drupalcode.org/project/ad/-/compare/4.0.x...10.x?from_projec... and 10.x is the same as 4.x!

anybody → closed merge request !27

OK I downgraded.