- Issue created by @prudloff
- Merge request !52[#3534898] fix: Don't consider a term replaced if it is in an element with glossify-exclude By: prudloff By: grevil → (Merged) created by prudloff
- Status changed to Needs review
7 days ago 3:13pm 8 September 2025 - First commit to issue fork.
- 🇩🇪Germany Grevil
Totally makes sense! Thanks for the fix!
I added a test to reproduce this issue. Here is the test output without the changes by @prudloff in place:
There was 1 failure: 1) Drupal\Tests\glossify\Unit\GlossifyBaseTest::testParseTooltipMatch with data set "set32" ('<div class="glossify-exclude"...ified.', [stdClass Object (...)], true, true, 'tooltips', false, '', '', '<div class="glossify-exclude"...ified.') Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'...><a>RT</a></div> Here is <span title="Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularized in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.">RT</span> that should be glossified.' +'...><a>RT</a></div> Here is RT that should be glossified.' /var/www/html/web/modules/custom/glossify/tests/src/Unit/GlossifyBaseTest.php:35
-
grevil →
committed 25a42481 on 3.x authored by
prudloff →
[#3534898] fix: Don't consider a term replaced if it is in an element...
-
grevil →
committed 25a42481 on 3.x authored by
prudloff →
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.