Don't replace term if there is already a link on this term in the page

✨ Glossify + Paragraphs: Multiple glossary links instead of one per node Postponed: needs info looks related?

This fix currently only covers the case, when the glossify type is set to "links" or "tooltips_links". This doesn't cover the 'tooltips' case. I understand that this is a bit confusing, as the "First match only" description is a bit wrong:

Match and LINK only the first occurrence per field

This setting also effects the tooltip creation, not only the link creation.

And I think we should put the logic into the "$text_nodes" foreach (in the reinserting first match if case), IF POSSIBLE! Might not be possible, as we exclude anchor tags in general, but maybe we can pass a flag, letting the reinsertion if case know, whats the case here.

Issue is unrelated.

Ok, "abbr" tags should be handled properly now through 🐛 "abbr" tags are not being excluded from the xpath query Active .

Now my concern in #6 is valid again:

This fix currently only covers the case, when the glossify type is set to "links" or "tooltips_links". This doesn't cover the 'tooltips' case. I understand that this is a bit confusing, as the "First match only" description is a bit wrong:

Match and LINK only the first occurrence per field

This setting also effects the tooltip creation, not only the link creation.

#4 Seems related.
I think the current MR there would fix this, no ?
Regards.

This issue only targets glossified words inside links per textfield not properly working with the "first_only" setting.
✨ Glossify + Paragraphs: Multiple glossary links instead of one per node Postponed: needs info seems to suggest a solution working across multiple textfields.

Alright LGTM! I added abbr support and added tests. LGTM! Thank you!

All green, merging.

Hi @grevil, thank you :) !

Automatically closed - issue fixed for 2 weeks with no activity.

Hmm I'm not sure about this change. We use the tooltip mode (we don't link to the tooltip term pages, we just use the tooltip abbreviations). With this change, if the term first appears in some link on the page, it doesn't get tooltip'ed anymore. I think it should. The link is not going to the term page in our case - it goes to some other page on the site. I think that's what #6 mentioned, but I'm not sure this was addressed? Maybe this new functionality should be limited to only configurations that use "links" or "tooltip_links" setups?