- Issue created by @prudloff
- Merge request !44Issue #3511457 by grevil, prudloff: Don't replace term if there is already a link on this term in the page → (Merged) created by prudloff
- 🇩🇪Germany Anybody Porta Westfalica
✨ Glossify + Paragraphs: Multiple glossary links instead of one per node Postponed: needs info looks related?
- First commit to issue fork.
- 🇩🇪Germany Grevil
This fix currently only covers the case, when the glossify type is set to "links" or "tooltips_links". This doesn't cover the 'tooltips' case. I understand that this is a bit confusing, as the "First match only" description is a bit wrong:
Match and LINK only the first occurrence per field
This setting also effects the tooltip creation, not only the link creation.
- 🇩🇪Germany Grevil
And I think we should put the logic into the "$text_nodes" foreach (in the reinserting first match if case), IF POSSIBLE! Might not be possible, as we exclude anchor tags in general, but maybe we can pass a flag, letting the reinsertion if case know, whats the case here.
- 🇩🇪Germany Grevil
Ok, "abbr" tags should be handled properly now through 🐛 "abbr" tags are not being excluded from the xpath query Active .
Now my concern in #6 is valid again:
This fix currently only covers the case, when the glossify type is set to "links" or "tooltips_links". This doesn't cover the 'tooltips' case. I understand that this is a bit confusing, as the "First match only" description is a bit wrong:
Match and LINK only the first occurrence per field
This setting also effects the tooltip creation, not only the link creation.
- 🇵🇹Portugal joao.ramos.costa
#4 Seems related.
I think the current MR there would fix this, no ?
Regards. - 🇩🇪Germany Grevil
This issue only targets glossified words inside links per textfield not properly working with the "first_only" setting.
✨ Glossify + Paragraphs: Multiple glossary links instead of one per node Postponed: needs info seems to suggest a solution working across multiple textfields. - 🇩🇪Germany Grevil
Alright LGTM! I added abbr support and added tests. LGTM! Thank you!
-
grevil →
committed 4b45024e on 3.x authored by
prudloff →
Issue #3511457 by grevil, prudloff: Don't replace term if there is...
-
grevil →
committed 4b45024e on 3.x authored by
prudloff →