- Issue created by @mondrake
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States smustgrave
Appears to need a rebase
If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- 🇮🇹Italy mondrake 🇮🇹
This touches 1,304 files, so it could become stale easily. I would encourage at reviewing as is also if not mergeable (at the end of the day this is again and again the same conversion pattern repeating), and then re-run the patch generation last minute before commit, if necessary. Otherwise we spend time running the same steps again with no value.
- 🇺🇸United States nicxvan
The way one managed these bulk conversions is outline the explicit steps taken so that someone can repeat them.
I convert them to added script and post them to agitlab snippet.
I clearly call out that it should be reviewed as a bulk conversion even if there are conflicts but that it should not be rtbc unless there are no conflicts just a comment with process review.
Then a couple of times a week I run the ddev script in a new branch on the issue.
You can see the most recent here: 📌 Bulk convert the remaining hooks to OOP Active