Updating to new tour module is causing config import issues

TypeError: Cannot assign null to property Drupal\tour\Entity\Tour::$module of type string in Drupal\Core\Entity\EntityBase->__construct() (line 75 of core/lib/Drupal/Core/Entity/EntityBase.php). Drupal\Core\Config\Entity\ConfigEntityBase->__construct(Array, 'tour') (Line: 114) Drupal\tour\Entity\Tour->__construct(Array, 'tour') (Line: 419) Drupal\Core\Entity\EntityStorageBase->mapFromStorageRecords(Array) (Line: 168) Drupal\Core\Config\Entity\ConfigEntityStorage->doLoadMultiple(Array) (Line: 313) Drupal\Core\Entity\EntityStorageBase->loadMultiple(Array) (Line: 97) Drupal\Core\Entity\EntityListBuilder->load() (Line: 73) Drupal\tour\TourListBuilder->load() (Line: 198) Drupal\tour\TourListBuilder->render() (Line: 23) Drupal\Core\Entity\Controller\EntityListController->listing('tour') call_user_func_array(Array, Array) (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 622) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28) Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 116) Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 90) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 53) Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 50) Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 53) Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 715) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comments & Activities

Issue created by @blu_regard
Comment about 1 month ago →
🇺🇸United States smustgrave
Not able to reproduce, was able to uninstall just fine.
Comment 27 days ago →
🇺🇸United States smustgrave
Someone just reported they got this error during drush updb
Comment 27 days ago →
🇷🇴Romania claudiu.cristea Arad 🇷🇴
I confirm this happens with 2.0.11 when installing on Drupal 10.5.1
Comment 27 days ago →
🇷🇴Romania claudiu.cristea Arad 🇷🇴
More info: One of my project's custom tour has the module set as NULL. As in core's tour this class property was not strict typed, NULL was accepted. It's simple for me to switch to an empty string, but I think this case should handled as part of update path process. Also, semantically, NULL might be a better choice for "no module"
Comment 10 days ago →
🇵🇹Portugal dxvargas
The module parameter was removed here for good reasons:
https://www.drupal.org/i/2443605 →

Then it was reintroduced here, but as I understand it wasn't well explained why we need this field.
https://www.drupal.org/project/tour/issues/3468446 🐛 Dependency calc seems to be removing all items Fixed
I think it was reintroduced to make the UI to continue to work. But there was no discussion why we need it back, no arguments against the points given in #2443605.
Also, now the schema doesn't have the module mapping! When I re export a configuration, the "module" info is removed from config.

I think the way to go is to remove again the module entry from the Tour class. And to remove it from the src/Form/TourForm.php, following the path that began in #2443605.
Merge request !106Issue #3533792 by blu_regard, smustgrave, claudiu.cristea: Updating to new... → (Merged) created by smustgrave

Comment 9 days ago →

System Message

smustgrave → committed e9b77709 on 2.0.x

Issue #3533792 by blu_regard, smustgrave, claudiu.cristea: Updating to...

Comment 9 days ago →
🇺🇸United States smustgrave

Updating to new tour module is causing config import issues

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!106Updating to new tour module is causing config import issues
Merged

Comments & Activities

Updating to new tour module is causing config import issues

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!106Updating to new tour module is causing config import issuesMerged

Comments & Activities

!106Updating to new tour module is causing config import issues
Merged