- Issue created by @littlepixiez
- Merge request !28#3533443 Updated check to be on every kernel request (although, this needs to be optimised) → (Open) created by littlepixiez
- 🇬🇧United Kingdom littlepixiez
Would be nice to get some feedback on this / the best approach here. I believe it's a challenge a lot of modules have, but I don't want to do too much refactoring, plus normal session timeouts may be enough for most people!
- 🇬🇧United Kingdom robert castelo
I can see the case for this, but suspect it's very rare that a website will need such up to the minute T&Cs compliance.
Would be nice as an option, but I wouldn't want to spend time on implementing something that may not be used much. If you need it for a project and want to develop it I'd be happy to review.
- 🇬🇧United Kingdom robert castelo
"move all module functions into separate services, so we are not using module functions within this service."
This feels like it should be a separate issue.
- 🇬🇧United Kingdom littlepixiez
Thanks! Yes that makes sense - plus I believe it would need some optimisation to live here, this solution is likely not comprehensive enough for others, so would need work.
I'll close this issue, and I'll make sure to raise another about centralising services etc and do some work. Thanks for the great module! :)