- Issue created by @amateescu
- Merge request !12519Ensure that persistent entity caches are not cleared when switching workspaces. → (Open) created by amateescu
- 🇺🇸United States smustgrave
Ran test-only job here https://git.drupalcode.org/issue/drupal-3532741/-/jobs/5695770 and got
1) Drupal\Tests\workspaces\Functional\WorkspaceSwitcherTest::testSwitchingWorkspaces Failed asserting that false is not false. /builds/issue/drupal-3532741/core/modules/workspaces/tests/src/Functional/WorkspaceSwitcherTest.php:82 FAILURES! Tests: 3, Assertions: 40, Failures: 1, PHPUnit Deprecations: 4.Leaning on the tests but locally workspaces seems to be working fine. Created 3, switched back n forth and tested basic functionality.
Any concern with removing protected variable $latestRevisionIds in contrib or custom modules?
- 🇷🇴Romania amateescu
Well.. that's very much internal to the content entity storage and I don't really see a reason for outside code/storage overrides to do something with it.
The alternative would be to add a new method specifically for clearing it, but I don't think that's preferable to the current approach from the MR. Core committers can decide I guess :)
- 🇬🇧United Kingdom catch
Overall I think the approach looks fine but should we try to use https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Dependenc... to deprecate the property - not with a bc layer just to warn any code trying to access it it's useless now?
- 🇷🇴Romania amateescu
While looking into @catch's suggestion and realizing that we can't use
DeprecatedServicePropertyTraitbecause that's specific to variables that store services (objects), I figured out that we can actually provide a proper deprecation strategy for this. Wrote a CR as well.Ready for reviews again :)