- Issue created by @jurgenhaas
- 🇩🇪Germany jurgenhaas Gottmadingen
Turns out, the solution is even simpler than that: there are only 2 places where the code depends on the toolbar module, and they can be called conditionally and all should be fine. That way, it's down to the user, if they want to enable the toolbar module or not.
- Merge request !61Issue #3531236 by jurgenhaas: Remove dependency from toolbar module → (Merged) created by jurgenhaas
-
jurgenhaas →
committed a4491c8c on 3.0.x
Issue #3531236 by jurgenhaas: Remove dependency from toolbar module
-
jurgenhaas →
committed a4491c8c on 3.0.x
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇩🇪Germany stefan.korn Jossgrund
Shouldn't there still be at least a hint somewhere (README?) that the toolbar module is required if gin toolbar is used without the navigation module? Or if technically not required, than something like a hint the toolbar module enhances the functionality of gin toolbar as long as navigation module is not enabled.
Currently with a minimal installation and just enabling Gin Toolbar nothing seems to happen. Some background things like style injections may still happen, but the toolbar itself is not visible. The toolbar only gets visible after enabling the toolbar module.
And if
When navigation is enabled, the toolbar module should be disabled.
When navigation is disabled, the toolbar module should be enabled.
is valid, why does the warning about that is surpressed from 🐛 Status warning: Toolbar and Navigation modules are both installed Active ?
May well be, that I am misunderstanding something here, but am bit puzzled about this now.