Remove gin_toolbar (and toolbar) from drupal_cms_admin_ui

We still need gin_toolbar, and as a dependency also the toolbar module. The reason being that with gin_toolbar we can inject Gin styling into the frontend, something that the admin theme can't do on its own.

Version 3 of gin_toolbar disables its own display which comes from a hook. Maybe your temporary issue was caused by a missing cache rebuild?

Maybe your temporary issue was caused by a missing cache rebuild?

That's possible although I only installed the site a day or two ago and hadn't touched it since - so caches might have been stale but they shouldn't have been outdated.

We still need gin_toolbar, and as a dependency also the toolbar module.

Could gin_toolbar remove the toolbar dependency though?

installed the site a day or two ago

We've fixed that in Gin and Gin Toolbar only a day or two ago, so maybe that was just an unfortunate overlap.

Could gin_toolbar remove the toolbar dependency though?

This may be possible for cases where navigation is not enabled. But if navigation is enabled, Gin and Gin Toolbar continue to behave like before Drupal 11.2. This is a bit of a nightmare, I know. Sounds like we only get rid of this when toolbar got deprecated and removed.

Not sure I understand.

Navigation module prevents the toolbar module from rendering. So why would toolbar module be required when navigation is enabled?

Sorry, I mistyped the second case in #4 and just corrected it.

So, here are the scenarios:

• Navigation enabled: Gin Toolbar may not require toolbar, but that needs to be verified. At least it suppresses its display.
• Navigation disabled: Gin Toolbar requires toolbar and displays like before

OK that makes more sense.

Navigation disabled: Gin Toolbar requires toolbar and displays like before

I think this could be handled with a ::moduleExists() check and maybe hook_requirements() if neither navigation nor toolbar are enabled.

Ah thanks for updating, although I think the first sentence is also reversed there still?

You're right, now corrected as well. Looks like my caffeine level is not sufficient yet.

I think this could be handled...

I need to take some time testing this. We would then have to automatically enable/disable toolbar when navigation gets disabled/enabled.

Won't be able to look into that before next week, though.

Turns out, we can make lives even easier. With ✨ Remove dependency from toolbar module Active and 🐛 Gin makes Navigation toolbar position fixed Active it's possible to make the toolbar module completely optional, and it requires only minor changes.

As a result, if neither navigation nor toolbar is enabled, Gin and Gin Toolbar still work properly, there's just no toolbar, but that's fine.

Waiting for a review in Gin Toolbar, the change in Gin has already been pushed to the dev release as it is a safeguard that should have been there already before.

@catch this has now been resolved in Gin and Gin Toolbar. Patch releases will follow later today.

Here in Drupal CMS, there doesn't seem to be any todo, so it can possibly be closed.

Confirmed by @catch on Slack.