Attachments on tasks are overwritten

It seems like the issue is that when the comment is saved, the task save is not triggered afterwards, so it doesn't ever run this presave until someone resaves it.

This push I did fixes this, however since the comments list, but not the whole view is reloaded via ajax, you won't see it until you reload the page. Follow up issue or should that be fixed here?

hi marcus, this change doesn't fix the issue with attachments, in my case I'm not working with comments at all. Here's a reproduction:

// Load a file that already exists.
$file = \Drupal\file\Entity\File::load(1);

// Create a new task.
$mytask = \Drupal\minikanban\Entity\Task::create();

// Add the file to the task and save.
$mytask->get('attachements')->appendItem($file);
$mytask->save();

// Should be 1, actual 0 because it's overwritten in Task::preSave line 156.
print $mytask->get('attachements')->count();

Sorry, I should have read the description clearer - we catched a bug this way though. The fix now makes sure that any incoming or already manually saved attachement should be kept.

So it takes the current attachments and adds any potential attachements from the description or a comment.

This means that if you remove a file from the description, it will still be kept as an attachment. A follow up task could be that its possible manually to remove attachments.

Looks good, thanks!

Rebased, fixed typo in line with 🐛 Fix typo in "Attachments" field Active and merged, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.