- Issue created by @catch
- Merge request !12332Ensure only enabled links are loaded in SystemMenuBlock. → (Open) created by catch
- 🇬🇧United Kingdom catch
This is a one-liner apart from the comment changes and performance test update.
While the performance test only shows that the query is updated rather than the improvement itself (the Umami main menu doesn't have any disabled items) that's enough to ensure that this won't regress accidentally.
I think having this many disabled menu links is not very common, but since we already filter the links out when building the tree after manipulators run, there's going to be no functional change for sites.
- 🇬🇧United Kingdom catch
This breaks workspaces menu integration - e.g. menu links that only exist in a workspace don't get shown in the workspace.
There are two ways to fix that:
1. Add an optional bool argument to ::onlyEnabledLinks() so that the condition can be removed in WorkspacesMenuTreeStorage::loadTree() - essentially undoing the optimisation added here, but only when viewing a workspaces.
2. Bring wse_menu into core, which makes the entire tree storage workspace-enabled.
I'll see if I can get #1 going quickly.
- 🇬🇧United Kingdom catch
Another way to deal with the workspaces issue would be to only add the ::onlyEnabledLinks() call in SystemMenublock if workspaces isn't enabled, but that would require a ::moduleExists() check, however we could then have a follow-up for workspace-enabled menu trees which would eventually remove that @todo.
- 🇺🇸United States smustgrave
Appears to be 1 open thread @catch thoughts on mstrelan comment?