Don't raise exception when an enum value is missing from meta:enum

Working on that as I get fatal errors with due to the change in the parent issue.

As discussed with @pdureau, regarding #3493070-61: SDC `enum` props should have translatable labels: use `meta:enum` → , changing status to postponed until we know in parent issue what to do.

Merge request is ready for review.

2 questions:

• Do we really need to keep ComponentMetadata::getEnumOptions() public method ?This method is very specific, maybe useless (checking the meta:enum value is enough) and not covered by an interface. Let's check this with the authors of [#16138734]
• Do we move the 3 alterations from ComponentMetadata::parseSchemaInfo() (add/remove/translate values to meta:enum) to a dedicated protected ComponentMetadata::makeEnumLabelsTranslatable() method?

The changes look fine to me.

Setting to RTBC so @pdureau can commit this during his work day

That's great, Larowlan.

Before committing, we will work on your feedback from the MR

And I will try to get the answer to this questions:

Do we really need to keep ComponentMetadata::getEnumOptions() public method ?This method is very specific, maybe useless (checking the meta:enum value is enough) and not covered by an interface. Let's check this with the authors of ✨ Enum vales do not have translatable labels Active

NR for #14.

Review comment addressed, thanks @larowlan!

Some concerns with DX + test coverage.

Thanks @penyakisto, we are carefully studying your feedbacks.

You wrote:

I'm fine removing the getEnumOptions method, but we would lose all translatability coverage if we remove this test.

So, you are fine removing this method if we don't lose such coverage. That would be great. We will try that.

Hi,

@penyakisto review comments addressed. We are available to discuss before tonight commit.

@grimreaper, we can improve a bit the implementation by casting the label as a string when extracting it from the enum value.

Per @pdureau in Slack.

While working on comment #20, Grimreaper is also completing and consolidating the unit tests.

The changes look good to me, I've pinged @penyaskito for a +1

I think I spotted one important piece of missing test coverage plus some questions.

Hi,

Replied to review comments.

There's one thing I don't understand, but it seems to be because I give JSON Schema to much credit.

Thanks for the pointers, @grimreaper — I found it a bit hard to connect all the dots, but you helped me do so — much appreciated! 🙏

larowlan → credited catch → .

Crediting others who I discussed this with on Slack

Committed to 11.x and backported to 11.2.x

Thanks all

Updated change record

larowlan → closed merge request !12326