- Issue created by @kim.pepper
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
I reverted the autowiring of SearchApiConverter as the BC logic in there was too complex. Created a follow up for that ๐ [PP-1] Autowire SearchApiConverter service Postponed
- ๐ฆ๐บAustralia acbramley
This is looking great, manually verified all the service aliases match the classes/interfaces of the services.
Some of these services probably don't need aliases as they're unlikely to be autowired (e.g the event subscriber or param converter) but I don't think there's any harm in adding htem.
- Status changed to RTBC
about 1 month ago 3:19pm 24 August 2025 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
drunken monkey โ made their first commit to this issueโs fork.
- ๐ฆ๐นAustria drunken monkey Vienna, Austria
Thanks a lot for creating this issue and already providing a great MR!
Looked pretty good to me, just fixed merge conflicts and amended. (Also, I wasnโt aware or had already forgotten you could omit the constructor doc blocks โฆ As it is allowed, I guess it really does make sense to drop them. Created ๐ Clean up (service) constructors Active as a follow-up for other classes.)
Also:
Some of these services probably don't need aliases as they're unlikely to be autowired (e.g the event subscriber or param converter) but I don't think there's any harm in adding htem.
I do: backwards compatibility. As soon as we define the class name as a service key we cannot just swap out the class anymore.
Therefore, I removed the aliases for all services that donโt have an interface. I think this should still cover all that are likely to be actually autowired anywhere.Please review! And thanks a lot, again!
- ๐ฆ๐นAustria drunken monkey Vienna, Austria
Good to hear, thanks for your feedback!
Merged.
Thanks again, everyone! -
drunken monkey โ
committed debe9dd4 on 8.x-1.x authored by
kim.pepper โ
[#3528042] feat: Added autowiring and aliases to our services. By: kim....
-
drunken monkey โ
committed debe9dd4 on 8.x-1.x authored by
kim.pepper โ