- Issue created by @huzooka
- Merge request !38Issue #3527977: Forms using entity builders of RDF Sync cannot be serialized β (Merged) created by huzooka
- π§πͺBelgium herved
I was able to reproduce easily, and the proposed changes are fixing the issue.
I just left a comment regarding the whole FieldConfigFormAlter/BundleEntityFormAlter/AbstractFormAlter/FormAlterInterface setup which is convoluted and unnecessary IMO, and could be done in just 1 service class, which may result in a more flexible architecture.
But this is probably OOS, and needs maintainer feedback. - ππΊHungary huzooka Hungary ππΊπͺπΊ
I addressed review feedback, created π Convert FieldConfigFormAlter and BundleEntityFormAlter to a single service Active as a follow-up; also added some comments for our future selves.
- π§πͺBelgium herved
I tested manually both forms, adding a button that rebuilds the form, no errors anymore.
+1 LGTM, thanks - π·π΄Romania claudiu.cristea Arad π·π΄
claudiu.cristea β made their first commit to this issueβs fork.
-
claudiu.cristea β
committed ced2d4b4 on 1.x authored by
huzooka β
Issue #3527977 by huzooka, herved: Forms using entity builders of RDF...
-
claudiu.cristea β
committed ced2d4b4 on 1.x authored by
huzooka β
Automatically closed - issue fixed for 2 weeks with no activity.