Package Manager's direct-write mode still tries to check for rsync

Created on 30 May 2025, 3 days ago

Problem/Motivation

In direct-write mode, it should be possible to configure an invalid path to rsync and Package Manager should not have a problem with that, since rsync is not used in direct-write. However, you will get a validation error because Package Manager forgets to bypass a Composer Stager precondition that checks for rsync.

Steps to reproduce

Set up Package Manager in direct-write mode (Project Browser just implemented support for it) and configure a random path in package_manager.settings:executables.rsync. It'll fail.

Proposed resolution

Bypass the PhpTuf\ComposerStager\API\Precondition\Service\RsyncIsAvailableInterface used by Composer Stager. Package Manager already has the infrastructure to do this.

πŸ› Bug report
Status

Active

Version

11.0 πŸ”₯

Component

package_manager.module

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024