- Issue created by @bnjmnm
- 🇺🇸United States bnjmnm Ann Arbor, MI
Overview
- Add text-based test cases to xb_test_state_api module.
- As part of getting those tests to pass Make the text components use native elements instead of radix
- Even if the text inputs can't look identical, it should look pretty close. More formal designs will be provided in the future so there's no need to be pixel perfect if it prevents the functionality from happening.
Proposed resolution
Manual Test
Enable xb_test_state_api module and try the inputs added in this MR
- First commit to issue fork.
- 🇺🇸United States bnjmnm Ann Arbor, MI
The final form element is de-Radix'd, which should make things easier & more stable 😎
- 🇫🇮Finland lauriii Finland
This was a pretty major regression for the styling of the textfields:
Before:
After:
- 🇺🇸United States bnjmnm Ann Arbor, MI
The mr
3526866-pretty-major-regression
updated some CSS and here's a comparison of the MR to HEAD.
- 🇺🇸United States hooroomoo
I noticed that this focus color for the TextField is different from the focus color of TextAreas. (because text area hasn't been de-radixified yet and I think is just using the color defined in the top level Radix theme wrapper)
I understand the appearance will be updated after designs are finalized, but until then, I think the focus colors should still be consistent across TextField and TextArea since they were consistent before.
Maybe we can we just change the TextField focus color to be the radix default for now instead of updating an out of scope TextArea here.
-
hooroomoo →
committed 37ac68e1 on 0.x authored by
bnjmnm →
Issue #3526866 by bnjmnm, jessebaker: Get Semi-coupled Text form...
-
hooroomoo →
committed 37ac68e1 on 0.x authored by
bnjmnm →