Update PHPStan to 2.1.17

Let's do 📌 [CI] Run PHPStan job on PHP 8.4 Active first.

📌 [CI] Run PHPStan job on PHP 8.4 Active is taking longer, let's try do this for 11.2

I think it's about time to drop support for PHPStan 1... in any case the baseline would differ significantly.

Seems like a straight forward update that didn't break anything. LGTM

📌 Update PHPStan to 2.1.17 Active is also RTBC by the way

This will conflict with 📌 Update Composer dependencies for 11.2.0 Active and Composer is more critical from a security perspective, so we're going to work on that one first.

📌 Update Composer dependencies for 11.2.0 Active is in now, so this can be rerolled.

📌 Fix phpstan errors in UpdatePathTestTrait Active just went in and took a nice big chunk out of the baseline, so that will want regenerating here alongside the composer.lock and whatnot.

on it

done

Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!

catch → closed merge request !12206

xjm → credited cmlara → .

So everyone (including me) was in a bit of a rush to get this in because of the RC, but in the process we overloooked the disruptiveness of this:

-        "mglaman/phpstan-drupal": "^1.2.11 || ^2.0.4",
+        "mglaman/phpstan-drupal": "^2.0.7",

-        "phpstan/phpstan": "^1.12.4 || ^2.1.14",
-        "phpstan/phpstan-phpunit": "^1.3.16 || ^2.0.6",
+        "phpstan/phpstan": "^2.1.17",
+        "phpstan/phpstan-phpunit": "^2.0.6",

That's removing the backwards-compatibility that was added in 📌 Bump PHPStan to version 2.0.0 Active . As @cmlara identified, 237 contributed projects use PHPStan ^1, so it's unfortunately not a small disruption, especially in a week-late RC for something that should have been in before beta.

For now, I've added a reference to PHPStan's upgrade guide to the release note, but we should keep an eye on this and see if there's anything we need to do to mitigate the situation for contrib in a patch release or hotfix.

Automatically closed - issue fixed for 2 weeks with no activity.