- Issue created by @mkinnune
- Merge request !33Resolve #3524258 "Configurable javascript plugins" β (Merged) created by mkinnune
- πΊπΈUnited States ari.saves New Mexico
This is an excellent solution @mkinnune -- my two main suggestions below:
1 - If regex validation depends on bool in step 4 being checked, the input for it should be conditional as well, or visually not enabled
2 - Wondering if this makes @timozura's earlier filter plugin scaffolding redundant or confusing -
ari.saves β
committed 8cd167ec on 1.0.x authored by
mkinnune β
Resolve #3524258 "Configurable javascript plugins"
-
ari.saves β
committed 8cd167ec on 1.0.x authored by
mkinnune β
- πΊπΈUnited States mkinnune
I do think it probably makes the filter plugin a little more confusing because of the way they are named. But I don't think it's redundant. The filter plugins are more for adding filters to the request that is sent to the API for Google to use when curating some results. I tried to make this plugin type as more of a generic JS plugin even though the main use-case for it right now is to essentially 'filter-out' or block content from being sent in any requests, but it could be used in the future for anything that might require someone to add some kind of javascript to the search page where they'd need to have some configuration added to it that is specified by an admin.
Automatically closed - issue fixed for 2 weeks with no activity.