Subsequent recipes installation breaks because of gin config from drupal_cms_admin_ui

I agree; there's no particular reason for this recipe to compare config strictly. RTBC if tests pass.

On second thought...although I approve of the fix, I am kind of wondering how this is happening. The drupal_cms_admin_ui recipe, like all our recipes, has a test which proves it can be applied twice. So something else must be modifying the block and making it deviate from our shipped config.

Again - I think that setting strict: false is completely fine, and the MR is RTBC. But I want to more thoroughly understand the problem before I merge this, just in case it points to a larger bug that needs a more comprehensive fix.

Can you provide steps to reproduce, starting from a bare Drupal CMS site -- or whatever it is you started with?

Thanks, we are currently working on creating recipes → based on Drupal CMS for our Lupus Decoupled → stack. To provide a streamlined editing experience we base all our recipes on the drupal_cms_starter recipe. That's how we noticed that issue.

To reproduce it using only drupal_cms recipes:

* Fresh Drupal install
* Apply drupal_cms_starter recipe
* Apply drupal_cms_news recipe
* Apply drupal_cms_starter recipe again

It fails because the gin_messages-block's weight got altered.

we base all our recipes on the drupal_cms_starter recipe

So this is the one recipe in our stack which is not meant to be applied more than once. I would suggest not using this recipe, and instead compose your recipe using the smaller parts of Drupal CMS (such as drupal_cms_admin_ui, or any of the other recipes we have, except for drupal_cms_starter).

But, having said that, I think I'm still okay merging this patch. There's no harm in making drupal_cms_admin_ui non-strict.

Merged into 1.x and cherry-picked to 1.1.x. Thanks!