- Issue created by @longwave
- ๐ฌ๐งUnited Kingdom longwave UK
I was wrong about
Select::hasAllTags()
and friends, but we can tighten up many of the other skips and remove a few - two where our implementations have been removed and one where we don't need to use a custom stub in a test. - ๐ฎ๐นItaly mondrake ๐ฎ๐น
This tells me it would be great to find a way to report ignored deprecations that are no longer necessaryโฆ like PHPStan does. Will be hard though as PHPUnit tests are run in parallel jobs in Drupal and results would need some sort of consolidation.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
Oh my... entered comment in the issue tags field...
Couple of nits inline, NW just to have a look
- ๐ฌ๐งUnited Kingdom longwave UK
Thanks for reviewing. I split out the PHPUnit one but think we should leave DrupalSelenium2Driver for now.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
Seems all good to me, we are narrowing the ignores so FTW.
- ๐ฌ๐งUnited Kingdom longwave UK
Thanks again - let's try to get this into 11.2 so contrib actually finds out about some of these that may have previously been skipped.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
Filed โจ Report usage of deprecation ignores during test runs Active to explore #7.
- ๐ณ๐ฟNew Zealand quietone
Everything looks in order here and the followup was made to find a better way. I read the MR and the changes look correct to me as well.
-
larowlan โ
committed 69852494 on 11.2.x
Issue #3523383 by longwave, mondrake, quietone: Tidy up and tighten...
-
larowlan โ
committed 69852494 on 11.2.x
-
larowlan โ
committed 90461b18 on 11.x
Issue #3523383 by longwave, mondrake, quietone: Tidy up and tighten...
-
larowlan โ
committed 90461b18 on 11.x
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Committed to 11.x and backported to 11.2.x thanks folks
Automatically closed - issue fixed for 2 weeks with no activity.