Use number_format() instead of round() on ByteSizeMarkup::create()

Created on 8 May 2025, 2 days ago

Cosinder this piece of code:

ByteSizeMarkup::create(932023)

We expect it to return 910,18 KB, but in fact it returns 910.1799999999999 KB.

This is because round() is not working properly and number_format() should be used to display rounded value.

🐛 Bug report

Status

Needs work

Version

11.1 🔥

Component

base system

Created by

🇵🇱Poland gugalamaciek

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @gugalamaciek
Comment 2 days ago →
🇵🇱Poland gugalamaciek
Proposed patch to fix fix the problem.
Comment 2 days ago →
🇵🇱Poland gugalamaciek
Comment 2 days ago →
🇺🇸United States smustgrave
Issue summary is incomplete

Should include the full summary template, with steps to reproduce

Also all fixes should be in MRs and as a bug will need test coverage.

Production build 0.71.5 2024