Remove -settings from Search settings page path

Removed -settings from Search settings page path. The issue needs review.
Previous Path:

Altered Path:

Thanks @chhavi.sharma that looks much better. It looks like the test needs to be updated as well :)

It's this one:

admin_toolbar_search/tests/src/Functional/AdminToolbarSearchSettingsFormTest.php

Indeed, great catch @ressa! 👍

I've just made the change to the MR and it is back to passing 🟢
Glad we have tests in place 🙂

Moving issue back to Needs review, for a final confirmation, before it gets merged 👌

Thanks again for all the great help!

Thanks @dydave, for a speedy reply and update as always!

The path is fixed and the tests are green (I agree, tests really are great, when they catch these small, easily overlooked details) so let's ship it! 🚀

Thanks a lot @ressa and @chhavi.sharma for your great help on this issue! 🙏

Following your confirmation at #8, I went ahead and merged the changes above at #9 👌

Another issue to scratch off our list, included in the next release! 🥳

Getting closer to the release date ... Let's see what else we could squeeze in 😅

Thanks again @ressa for suggesting these issues and @chhavi.sharma for your help with the code changes!

Thanks @chhavi.sharma and @dydave for fixing this so fast, with lightning speed! ⚡

Awesome to get another little improvement included, before release. Thanks!