Set search result lists font colour to black

ressa → changed the visibility of the branch 3.x to hidden.

Thanks a lot @ressa once again for suggesting this change!

I checked quickly to see the color contrasts: https://webaim.org/resources/contrastchecker/

Currently: #003ECC in front of #FFFFFF
gives a ratio of: 8.19:1

I "think" it should be fine to update the default color of the search items links to something darker to increase the color contrast 👍

So I added a commit to your merge request above at #6, mostly to:

• Decrease slightly color contrast from 21:1 to 12.63:1
• Update search field placeholder label to include shortcut, as suggested in #3494646-17: Access Admin Toolbar search field via keyboard shortcut Alt + a →

 
I was a bit worried about adding a static value to override the link color, but it seems the module currently uses CSS static values everywhere 😅

Overall, I think the module should consider refactoring all static values in CSS files to use CSS variables instead, defined by the module or themes/core/defaults.
See for example:
https://git.drupalcode.org/project/klaro/-/blob/3.x/css/klaro-override.c...
But this is definitely out of scope and should be addressed in different tickets 😅

Let's focus on preparing this release and we'll get more technical debt issues fixed in the next one 👌

Thanks in advance for your feedback! 🙂

You're welcome @dydave 🙂

And great that you checked the contrast. But, as I see it #000000 (black) would give the optimal contrast, being black text on white background, and don't we want maximum contrast?

But #333333 also works well, since it's not blue, so that's an improvement, and totally fine. Also aesthetically, it could be more pleasing -- so I'll RTBC it!

Switching to CSS variables is a good idea, if it makes development and maintenance easier, going forward. Though I do also see advantages in keeping it simple -- there are pros and cons for each method, as always. For example, looking at the Klaro CSS you shared, I get an "eyes glaze over" feeling -- it looks very complicated to me 😅

Thanks a lot @ressa once again for your prompt and positive feedback! 🥳

Once again, following your reply, I went ahead and merged the changes above at #9 👍

Let's stay focused on the current tickets for now and maybe come back to CSS variables later, when we have more time, I guess 😅

Marking issue as Fixed for now:
That's one more included in the next release, great work!

We can still squeeze in more issues in this release, so feel free to let us know if you spot anything else, we would certainly be very grateful!🙏
Thanks again for all your great help!