- Issue created by @jwilson3
- Merge request !11983Issue #3521857 by jwilson3: Update file type icons to use SVG β (Open) created by jwilson3
- πͺπ¨Ecuador jwilson3
Hrm. The test fail seems unrelated.
Drupal\Tests\node\Functional\NodeRevisionsAll The string "page=1" was not found anywhere in the HTML response of the current page.
- πͺπ¨Ecuador jwilson3
Add the new high-resolution SVGs files alongside existing low-resolution PNGs in all themes shipped with Drupal core. Do not remove old PNG files from the codebase. Add cleanup task #3452493: [12.x] Remove images that have been replaced in core.
I'm having second thoughts about this in the context of the StarterKit theme. Certainly for Umami and Claro themes, we shouldnt remove the PNGs. However the StarterKit theme, when used as intended (if I understand correctly), is supposed to be a kind of "line in the sand" or fork of the codebase and a snapshot in time. This implies to me that we could easily remove the old PNG files and then any new themes created from the Starterkit would have a clean slate and no duplicitous files. Tech debt free!
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
I think this might get more attention if it were under theme system.
- πΊπΈUnited States smustgrave
MR needs to be updated for 11.x please.
- πͺπ¨Ecuador jwilson3
My apologies for starting from the wrong branch. I recreated the same existing MR branch name locally, cherry-picked the existing commits, and force-pushed to the existing MR. Back to NR.
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.