Publish checks validation constraints, but not form validation

(I set the Component to "Miscellaneous" because I'm unsure what this actually is. Closest seems to be autosave but this is about publishing - a separate process that is predicated on autosave, but is not autosave)

Thanks for the bug report!

It's ApiAutoSaveController::post(), which was originally called ApiPublishAllController by @tedbow and @larowlan in 📌 Create an endpoint to publish all auto-saved entities Active , so that seems the appropriate place. They wrote the logic + tests, so let's get their input.

Added a new issue this surfaces 🐛 Publishing the currently edit page causes 'another user has changed this content' error Active

Test-only CI job running: https://git.drupalcode.org/project/experience_builder/-/jobs/5130397

This is , so over to @tedbow for review.

Looks good to be. Needs /ui approval

Spotted a few little things mentioned in the MR

Addressed review and reinstated the alt text change needed for tests to pass

@bnjmnm's feedback has been addressed.

Also, Ben wrote:

Nice, happy to have this trojan horsed in here.

… about the dreaded all of us have been seeing increasingly often lately.

So … really wanted to merge this, but alas entity-form-field-types-test.cy.js is failing 😭

Test fail appears due to the change that removed the The content has either been modified by another user..." issue see comment

#13 sounds like @wim leers was ready to merge this, so assigning back to him

chatted with @wim leers myself or others(or wim) could review. I will look at this tomorrow if it still needs review

This looks good to me but publish-validation.cy.js has a merge conflict I tried merge locally but then this test fails. Not sure if was merge conflict resolution or something we the actual test. I am not pushing my merge because it would probably just make thing worse

Took care of the merge conflict and it looks like all other reviews were good with the changes so I'll go ahead and commit.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.