- Issue created by @joachim
- Merge request !108Issue # 3521558 by danrod: Deleted class property (and its docs) that is potentially not used. → (Merged) created by danrod
- 🇨🇦Canada danrod Ottawa
Hello @joachim I actually deleted the
$defaultsproperty and its docs, I don't see it being used anywhere in the class (or module). Please review. - 🇬🇧United Kingdom joachim
It's used in the parent class -- see DefaultPluginManager::processDefinition().
Come to think of it, the correct docs here would be an inherit doc tag, which is what inherited properties should have. That way it's clear that it's coming from a parent class.
- 🇨🇦Canada danrod Ottawa
Done, please review again, sorry for the commit comment, the
$defaultsstring was replaced with an empty string. Automatically closed - issue fixed for 2 weeks with no activity.