- Issue created by @prashant.c
- ๐ง๐ชBelgium wouters_f Leuven
Oh yes you are absolutely right.
Please provide a merge request, ill see when i have time to fix this haritha c โ changed the visibility of the branch 3519312-source-database-should to hidden.
haritha c โ changed the visibility of the branch 3519312-source-database-should to hidden.
haritha c โ changed the visibility of the branch 3519312-source-database-should to active.
haritha c โ changed the visibility of the branch 3519312-source-database to hidden.
I have updated the code to make the "Source database" field required in the block configuration form by adding:
'#required' => TRUE
This ensures that the search block cannot be saved without selecting a source, which helps prevent misconfiguration.
However, the merge request pipeline initially failed due to PHPStan static analysis and/or PHPCS code style issues.
If anyone could guide me on how to resolve this pipeline issue, I would greatly appreciate it.
Thank you!
- ๐ฎ๐ณIndia prashant.c Dharamshala
@haritha_C
Please check under the "Failed jobs" on this URL: https://git.drupalcode.org/project/ai_search_block/-/merge_requests/11/p...
- ๐ฎ๐ณIndia prashant.c Dharamshala
You may fix the PHPCS issues in this one https://www.drupal.org/project/ai_search_block/issues/3515395 ๐ Fix coding standards violations in AI Talk With Node module Active
Hi @prashant.c,
Thanks for your response.
I've resolved all the pipeline and PHPCS issues in this merge request itself:
๐ https://git.drupalcode.org/issue/ai_search_block-3519312/-/tree/3519312-...Kindly review and let me know if anything else is needed.
- ๐ฎ๐ณIndia sagartiwari
The Provided MR fixes the issue, although PHPCS still shows some issues.
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 6 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------
6 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
29 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
31 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
37 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
50 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
68 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
75 | ERROR | [x] Expected 1 newline at end of file; 3 found
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------FILE: /home/sagar/projects/contributions/contrib_project/modules/contrib/ai_search_block-3519312/modules/ai_search_block_log/README.md
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------FILE: /home/sagar/projects/contributions/contrib_project/modules/contrib/ai_search_block-3519312/modules/ai_talk_with_node/css/ai_talk_with_node.css
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
50 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
51 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------Thanks.