- Issue created by @godotislate
- 🇬🇧United Kingdom joachim
Does something for this need to be added to the core BC policy too?
- 🇬🇧United Kingdom catch
Once it exists we should add to the 'how to deprecate' page. For me this is a nicety that doesn't change the BC policy for forms though - there are plenty of form changes that would not be able to use this and we don't want to preclude ourselves from doing them. I also don't think we'd bother using this on obscure admin forms either.
- 🇳🇿New Zealand quietone
I agree with catch. Adding tag and item to the remaining tasks about updating the 'how to'.
Another thing to consider whether it's worth covering for the deprecation: Some form submit methods use
$form_state->getValues(), then reference a specific key on the array, e.g.$form_state->getValues()['confirm'];or$values = $form_state->getValues(); $confirm = $values['confirm'];.MR is ready.
Can't trigger deprecations for usages of
getValues()after all, so focusing strictly ongetValue().- Status changed to Needs review
about 2 months ago 8:47pm 26 June 2025 Updated deprecation version to 11.3 and refactored the test a little.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
This looks great - just had one question about some extra coverage for subform state which this code will run for, but we don't have any tests for in the MR yet
Rebased for the merge conflict.
Subform state should be accounted for now, and some logic issues fixed, with additional test coverage.The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Merge conflict because 📌 Slowly, very slowly start OOPifying the render system Needs review was reverted, but maybe just gonna wait to see if it gets back in soon.
