- Issue created by @balintbrews
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Text area props
I always have been concerned about that, and now even more so.
json-schema-definitions://experience_builder.module/textarea
is what @lauriii advocated for, but it really should bejson-schema-definitions://experience_builder.module/multiline_string
."textarea" is the only prop shape where the shape is pointing to the input UX instead of the shape/semantics of the data.
Make this new shape the default for text areas — we can assume all of them want a WYSIWYG editor;
IMHO we should just remove the "textarea" stuff and name this "HTML block" in the code component editor UI, which then closely matches the semantics:
type: string contentMediaType: text/html x-formatting-context: block
- 🇳🇱Netherlands balintbrews Amsterdam, NL
#3: Yes, that sounds great. I also discussed this with @lauriii, and we'll go with Formatted text to match the core field type's name. We also descoped displaying CKEditor in the code editor from this issue.
- Merge request !938#3519135: Formatted text props in code components → (Merged) created by Unnamed author
- 🇳🇱Netherlands balintbrews Amsterdam, NL
Note for reviews: before 📌 Support props that can use wysiwyg widgets Active is fixed, the props form of instantiated components will have an empty dropdown for selecting a text format.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Awesome to start see this coming together! 😄
We also descoped displaying CKEditor in the code editor from this issue.
Sounds reasonable! But then this needs a follow-up 😇
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Support props that can use wysiwyg widgets Active is in now, which makes this much nicer to work on and more valuable to finish :)
- First commit to issue fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
BE pieces + automatic-upgrade-path-upon-editing (the only backwards compatibility thing we've ever done, which feels odd, but it's so trivial that it is worth it) removal issue ( 📌 Remove backwards compatibility with "Text area" prop in code editor, superceded by "Formatted text" Postponed ) look good.
-
balintbrews →
committed e380266b on 0.x
Issue #3519135 by balintbrews, hooroomoo, wim leers, lauriii: Evolve "...
-
balintbrews →
committed e380266b on 0.x