Support props that can use wysiwyg widgets

Not much point working on this until we can get CKEditor 5 loading on textareas 📌 CKeditor not loading on formatted text fields in the content entity + component instance forms Active so postponing on that

The current MR is outdated to the point that it's probably not worth continuing, and will likely be less relevant after #3512867 so I'm going to hide that one and recommend a new MR starts once we have CKEditor 5 working in the fields that are configured to use it. #3512867 already has it the editor properly loading with formatted text fields in the Page Data form

bnjmnm → changed the visibility of the branch 3484395-wysiwyg-ckeditor5-widget to hidden.

bnjmnm → changed the visibility of the branch 3484395-support-props-that to hidden.

#5++ — thanks so much for assessing and summarizing this issue's status, @bnjmnm! 🙏😊

Per #3512867-11: CKEditor 5 not loading on formatted text Field Widgets in the content entity form → , retitling this to more precisely reflect this issue's scope.

📌 `StringSemanticsConstraint::MARKUP`: agree how SDC prop JSON schema can convey it should be markup, and Needs review is in.

I reviewed #3512867 to help it land: #3512867-14: CKEditor 5 not loading on formatted text Field Widgets in the content entity form → .

This will

📌 CKeditor not loading on formatted text fields in the content entity + component instance forms Active is in!

MR has it working, still need to add tests.

#13: exciting! 😄🤩

Note: the "inline" ones don't need to work, as described in ✨ [later phase] Make `x-formatting-context: inline` work Postponed . Sorry for making that not more clear, @bnjmnm :(

There are PHP tests failing due to there being commented-out props in the all-props sdc. These are props unrelated to the work happening here, but their presence results an error occurring any time a value changes on any prop in all-props. It is being worked on in this issue: 📌 `StringSemanticsConstraint::MARKUP`: agree how SDC prop JSON schema can convey it should be markup, and Needs review

They're commented for now so the work being done here can be reviewed manually and the CK5 e2e tests pass. That should be enough to get this reviewed, but we shouldn't commit until #3467959 lands and we un-comment those props.

🏓 Review posted!

It is being worked on in this issue: […]

That issue is closed, so did you perhaps intend to link to another issue?

I did some manual testing of this and noticed after the first update of the preview (in response to an edit in a CKE field) there is a flicker as the form is rebuilt and then CKE is reattached. And from that point editing the field value doesn't trigger an update anymore. Here's an example showing I've put 'Hi dog what's up more edits' in the field but it doesn't trigger an update in the preview.

\

This turned out to be a pretty big thing to address, but it's good this came up and I have the underlying issue fixed. Instead of relying on Drupal behaviors, this is now using the Ckeditor5 React Integration.

Now the editors work without flickering and the preview updates as you'd expect. However, I've been at this for far too long and the code is a bit scary looking so it's switched to draft. There's some cleanup + the format switching will need to be refactored a bit to work with the React-rendered CKEditor5 components. I think this is for the best as CKEditor5 is probably too complex to graft the Vanilla JS version onto our React forms if there's an official React solution available.

I'm unassigned myself in case someone wants to jump into the chaos, but I'll be back at it tomorrow.

Sorry @ anjali your name is right next to "Unassigned"

The flickering reported earlier wound up being a pretty big deal and I switched out the drupalBehaviors grafting to instead use the React solution from CKEditor themselves.

The only failing e2e test is the recently addedfield_xbt_entity_ref_tags which was added to day and should(?) be unrelated to anything here.

The MR should probably have gotten another once over from me before switching to NR, but I gotta leave the computer + this is high priority and probably good to get some eyes on it

Pausing the NR - spotted something locally that could be improved