- Issue created by @Grevil
- Merge request !27Issue #3519086: Outsource how different availabilities are displayed, based on the combination of "orderable" and "availability_status" → (Closed) created by Grevil
- 🇩🇪Germany Grevil
@anybody for the formatter setting, instead of having the boolean setting "show_availability_status" we could change it to "availability_status_display_mode" with 3 options:
- Don't display the availability status
- Display avaliability status
- Display "displayed" availability status (product of orderable and availability_status)
Or something along those lines. What do you think?
- 🇩🇪Germany Grevil
Ok, I also implemented a computed based field definition. This way, we don't need to do any template preprocessing, if we want to use the availability representation, and we can directly use the "availability_representation" field value.
- 🇩🇪Germany Grevil
Not completely finished yet, we still need the update hook, and deprecate the old "status_label". But first review pls.
- 🇩🇪Germany Anybody Porta Westfalica
I guess we should start with a fresh fork / MR. I don't see any reasons for modifications on the PHP-side. We already have a "component" = field formatter / twig template as abstraction layer that acts consistently. And that's basically what we want?
- 🇩🇪Germany Grevil
Updated issue summary. We won't touch the displayed label.
Unsure if this issue makes any sense anymore, I would find it very confusing, having two different states for "out_of_stock". At least for me "out_of_stock" means, an item is not orderable, but that is not the case, apparently.
- 🇩🇪Germany Grevil
Yea, let's simply close this... doesn't make much sense. It is fine as is and follows the google_merchant rules: https://support.google.com/merchants/answer/6324448?hl=en.