- Issue created by @balintbrews
- First commit to issue fork.
- Merge request !912Experimental UI for adding first-party import statements in code components → (Merged) created by hooroomoo
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
One point by @larowlan left to be addressed WRT the icon. It's low-risk to ignore in that it doesn't incur new technical debt though (we'd just have to change the icon later), so RTBC'ing to reflect it's technically ready! 👍
- 🇫🇮Finland lauriii Finland
I think we need to revisit the UI a bit. I don't think "Component data" is the right place to display this in. Is the import components tab simply an interface to give the imports that can be copy pasted? Or does selecting a component in that interface have side effects?
- 🇺🇸United States hooroomoo
No side effects, it's just an interface. Selecting a component from the select just generates the import statement in a code block
- 🇳🇱Netherlands balintbrews Amsterdam, NL
I made slight changes to the UI, and adjusted the list of code components to exclude code overrides and the currently edited component. Also addressed @jessebaker's comment on making the list alphabetically sorted based on the name of the components.
-
balintbrews →
committed bba1a170 on 0.x authored by
hooroomoo →
Issue #3518208 by hooroomoo, balintbrews, larowlan, jessebaker, lauriii...
-
balintbrews →
committed bba1a170 on 0.x authored by
hooroomoo →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This broke CI. The
stylelint
CI job is not passing.This was already not passing on the MR prior to merging: https://git.drupalcode.org/project/experience_builder/-/merge_requests/9... 😅
-
hooroomoo →
committed ad8fb850 on 0.x
Issue #3518208 by hooroomoo: Fix stylelint on 0.x
-
hooroomoo →
committed ad8fb850 on 0.x