- Issue created by @mandclu
- 🇨🇦Canada mandclu
The scope of changes in the MR may be wider than the maintainers are looking for, and if so I would be happy to tweak as needed. The changes in there do meet my need for creating a condition that works for moderated taxonomy terms, however.
- 🇨🇦Canada nickdjm
Yeah, it would be ideal for the 1 condition to apply to all entities, but I don't think there's a generic entity context.
This change makes sense to me. I'll test it out in a couple of projects I have using this module and see how it goes!
- 🇨🇦Canada mandclu
Circling back on this, @nickdjm any chance you've had a chance to review this yet? I would really like to use this module in the Drupal Event Platform → but I need something that supports taxonomy terms.
- 🇨🇦Canada nickdjm
Yes sorry, I got caught up in DrupalCamp Ottawa stuff.
The changes look good, and testing in a fresh environment works well- however, we'll need an update hook for projects already using this module since we're removing
moderation_state_condition_moderation_stateand replacing it withnode_moderation_state_condition_moderation_state. - 🇨🇦Canada mandclu
I've added an update hook which fixed an existing block in my test environment. Please review.