[1.0.x] Designated Proxy User

I have added Gitlab CI and applied fixes from PHPCS.

For clarity, I want to add that I have applied for coverage before, but the module I used for my previous application 📌 [1.0.x] Alternative Hreflang for SEO Active was much smaller than this one and did not contain sufficient code, so I closed the original application. Now that this project is ready to review I created it as a separate application, I hope that is OK.

I will review the project tomorrow.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that does not follow the coding standards, contains possible security issue, or does not correctly use the Drupal API
• The single review points are not ordered, not even by importance

src/Controller/ProxyUserController.php

Since that class does not use any method from the parent class, it does not need to use ControllerBase as parent class. Controllers do not need to have a parent class; as long as they implement \Drupal\Core\DependencyInjection\ContainerInjectionInterface, they are fine.

FILE: src/Form/CreateManagedUserForm.php

  /**
   * The current user service.
   *
   * @var \Drupal\Core\Session\AccountProxyInterface
   */
  protected $currentUser;

  /**
   * The configuration factory service.
   *
   * @var \Drupal\Core\Config\ConfigFactoryInterface
   */
  protected $configFactory;

FILE: src/Form/ManagerContactForm.php

  /**
   * The current user service.
   *
   * @var \Drupal\Core\Session\AccountProxyInterface
   */
  protected $currentUser;

The parent class FormBase already has properties and methods for the configuration factory, and current user service. There is no need to redefine properties for the same purpose; instead, the parent class methods should be used.

Thank you @avpaderno and @vishal.kadam for the reviews.

I have updated the module to address your feedback.

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank the dedicated reviewers as well.

Thank you very much @avpaderno

Automatically closed - issue fixed for 2 weeks with no activity.