Dynamic caption settings not applied

Patch attached.

Thanks for pointing this out. I left a comment on the MR.

@grevil: We're running into this in a client project, maybe you could have a look in the next days? See my comment in the MR.

Makes sense, I assumed the options were being deleted for some other reason, but if they're not hurting anything that's even simpler.

Well I think, there might have been a reason for that line, which we need to keep, but we should not alter the original value. I'm not deeply into this though.

grevil → closed merge request !130

I honestly have no idea why @segovia94 added this line in the original proof of concept in ✨ [5.x] PhotoSwipe 5 Branch Fixed . Doesn't make any sense to me. Interesting that this wasn't discovered before.

Thanks for the fix! Works like a charm. :)

Release 5.0.4: https://www.drupal.org/project/photoswipe/releases/5.0.4 →

Automatically closed - issue fixed for 2 weeks with no activity.