- Issue created by @wim leers
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Probably we don't even want users to focus on global regions (double-click). TODO: Confirm and create issue
- Merge request !854Issue #3516655: Omit `PageRegion` representation from ApiLayoutController::get(), 403 if sending it in `PATCH or POST → (Merged) created by penyaskito
- 🇫🇮Finland lauriii Finland
FYI, ✨ Non-empty global regions need to be highlighted when hovering with the green color Active is where we would allow users to double click a global region inside the preview to edit it.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Ready for another round of reviews.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
🏓I forgot about openapi until now, added that 🙈
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
::getRegion()
is still wrong, and theopenapi.yml
file was updated incorrectly.I recommend putting a breakpoint on
\Drupal\Tests\experience_builder\Kernel\ApiLayoutControllerPostTest::testMissingSlot()
and stepping through it — that's what I just did and it's how I observed the modified docs for::getRegion()
to be wrong in multiple ways 😅Let's spend the 10–20 mins it takes to get this right now, otherwise this will continue to cause confusion! 🙏
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This last bit now is perhaps genuinely nitpicky, but I find
::getRegionComponents()
genuinely confusing 🙈I'd prefer to see https://git.drupalcode.org/project/experience_builder/-/merge_requests/8... get fixed, but if you disagree: I've approved the MR and marked this RTBC :)
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
#20 suggestion is great, I'll fix that.
-
wim leers →
committed 12a932a0 on 0.x authored by
penyaskito →
Issue #3516655 by penyaskito, wim leers, lauriii, larowlan: Omit `...
-
wim leers →
committed 12a932a0 on 0.x authored by
penyaskito →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Probably we don't even want users to focus on global regions (double-click). TODO: Confirm and create issue
They won't be able to, because the regions will simply not appear in the information the server sends to the client; the client won't even know about these regions! 👍 So: no follow-up needed.
Issues identified for the Content Editor role:
- Experience Builder: Article Editor link is visible and clickable
Steps to reproduce:
- Log in as a Content Editor.
- Go to the Content page.
- Click on the title of any Article created by an Admin (for example: Test Page).
- In the header, the Experience Builder: Test Page link is visible and clickable.
- Clicking this link redirects to the node editor page and shows the following error:
An unexpected error has occurred while fetching layouts.
-
Error while publishing an Article
When creating a new Article page as a Content Editor and attempting to publish it, the following error appears:
You do not have access to transition from Draft to Draft.
- Experience Builder: Article Editor link is visible and clickable
Issues identified for the Content Editor is not related to this issue.