- Issue created by @amateescu
- 🇷🇴Romania amateescu
The test failures are not caused by this MR, see 🐛 Fix failing PHPunit tests Active .
\Drupal\group_content_menu\Form\GroupContentMenuForm::submitOverviewForm() uses a strict comparison when checking whether the weight, parent or enabled fields were changed, and this is problematic for the enabled field because it checks a #default_value = TRUE to #value = 1.
Note that core's menu form doesn't use a strict comparison in \Drupal\menu_ui\MenuForm::submitOverviewForm() for the same reason.
The easiest way to reproduce this is with the Workspaces module:
- reorder some child menu items in a workspace
- save the form
- navigate to the workspace overview page and notice that all menu links are now updated, not just the siblings of the reordered item
Use a non-strict comparison, just like the core menu form.
Review.
Nope.
Nope.
Nope.
Active
3.0
Code
The test failures are not caused by this MR, see 🐛 Fix failing PHPunit tests Active .