ComponentValidator ignores the set validator and creates a new one

Can't re-run the test but failure appears to be in nightwatch /builds/project/drupal/core/modules/toolbar/tests/src/Nightwatch/Tests/toolbarTest.js:50

So pretty sure it's random.

Left a comment on the MR.

Addressed that thanks!

That was all the feedback I had thanks!

This is blocking for adding autocomplete support to link field widgets in Experience Builder

Was wondering what for XB this was impacting haha :)

More fundamental question: should we reset the validator before each time we try to use it, instead of after?

Addressed the review feedback and implemented #9 because that makes sense to me.

larowlan → credited lauriii → .

I feel a bit uneasy about the test case. The existing tests run through a number of valid and invalid scenarios for the default validator. But currently you're replacing the default validator, so now we don't know if the scenarios would pass or fail with the original validator.

I think instead we should have an additional test case that is explicitly to test that swapping out the validator is respected by ::validateProps.

Yep, you're right - I've done that - thanks for the review!

This looks awesome!

This AFAICT also opens the door to defining custom formats, for example:

image_url:
  type: string
  format: url--image

or

code_snippet:
  type: string
  format: multi-line

or …

That likely would be a better DX than the use of $ref in Experience Builder… food for thought! 🤓

Committed 914ecc3 and pushed to 11.x. Cherry-picked all the way back to 10.4.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.