I added a base field to a custom entity by a hook_entity_base_field_info(). I added it this way because we need the base field across multiple entity types; both custom and core.
After adding the base field, the autocomplete on the 'Revision User' filter for our view stopped working. It became a text field.
Tracing the issue found this code to be the likely issue.
if ($revision_table && ($revision_uid_key = $this->entityType->getRevisionMetadataKeys()['revision_user'] ?? '')) {
$data[$revision_table][$revision_uid_key]['filter']['id'] = 'user_name';
}
The $revision_table at that point in the execution was using the value for the new base field, rather than the entity base revision table. The value of that is overridden in a loop that processes the field_definitions.
Update the loop that processes the field definitions to not reuse / overwrite the variable that is set (and used) at a higher scope.
Active
11.0 🔥
views.module
Thanks for reporting.
Something that will be needed is a test case showing the issue.
From what I can tell are this is doing is changing the parameter name from $revision_table to $field_revision_table
Maybe the IS needs to be clearer.