Convert from annotations to attributes

Agreed, we should always use the latest standards. We're already working on that for all sorts of annotations that are in ECA, so it should be done here and in bpmn_io as well.

The issue I encountered in 🐛 Refactor breaks eca_ui Active was actually caused while working on this issue. It's obvious why now that I think about it a bit. I was able to create the Attributes, but need to use the "backwards compatibility" strategy outlined here: https://www.drupal.org/node/3395582 →

I'm going to create follow up issues for the ECA and BPMN.io modules to convert their plugins to use the Attribute syntax. I wonder if it would be helpful to keep the backwards compatibility implementation around until folks get used to writing Attributes instead of Annotations.

I also noticed that the way we are actually using the properties of the Annotation/Attribute is to put TranslateableMarkup in there (instead of just a string). Is it best to keep the property's data type to be a string instead of a TranslateableMarkup?

We already have issues about attributes and there are people already working on it. I don't think we need to do a lot now for ECA or bpmn_io, they are both in good shape.

Here is the ECA issue that already exists for this topic: 📌 Convert plugin annotations to attributes Active

And bpmn_io only has 1 plugin which will have to be converted when the modeler plugin interface will have been converted.

That's great that folks are working on converting Annotations to Attributes in general.

I was specifically talking about the new plugin types that we are introducing in modeler_api. Without the backwards compatibility built into the Modeler and ModelOwner plugin managers, we will have the bugs I mentioned. I have quick fixes ready for:

• Drupal\eca_ui\Plugin\modeler_api_model_owner\Eca
• Drupal\bpmn_io\Plugin\modeler_api_modeler\BpmnIo

Both are the only ones (so far) to implement modeler_apis plugins. I'll go ahead and create issues and fixes for these and get this all wrapped up.

That makes sense !

Fixed this together with the 2 implementations at ECA and bpmn_io.