Refactor breaks eca_ui

It's not only the entity collection route, it's also the import, the settings, all the entity related routes (edit, clone, export, etc.) are handled by modeler_api. So, I think it makes more sense to declare the modeler_api as a hard dependency for eca_ui, then all that is available when eca_ui will be enabled anyways. And it will save all the other implementations of ModelOwners a lot of repetitive work as they will just inherit all of that ootb.

jurgenhaas → closed merge request !489

I've committed that fix to the dev branch directly.

Issue still occurs if you:

1. Start with a new Drupal 11-dev site
2. Enable eca
3. Enable eca_ui

Enabling eca_ui fails because it depends on a route that modeler_api creates. I'm even seeing the issue if I ensure that modeler_api is enabled first. I've cleared my cache a tone of times.

I think a different approach might be needed. Maybe if we use the same route_callback approach so we can programmatically set the route. We could check if the route already exists and if it doesn't, create a stub of the route. That way modeler_api can overwrite the route if eca_ui is installed first and eca_ui won't overwrite the route if modeler_api is installed first.

I can't reproduce this. Here are my steps that I've taken:

1. drush si
2. drush en eca_ui

Then I go to /admin/config/workflow/eca and all looks fine.

Note, step 2, when enabling eca_ui, that also enables eca and modeler_api, as both are dependencies of eca_ui, and that provides all the route required.

If this still doesn't work for you, please have a look in the logs an if that doesn't tell us anything, then it's time for xdebug. And a good point will be to inspect \Drupal\modeler_api\Routing\Routes::routes to see which routes get created and which ones are not and why.

That's good to hear. Yea. checking if there's anything on my end that could be the issue.

The issue here isn't actually the eca_ui module but rather that 📌 Convert from annotations to attributes Active broke compatibility with the annotations. I fixed the issue there, by using the backwards compatibility implementation outlined here: https://www.drupal.org/node/3395582 →

With that issue resolved the main issue I originally spoke about has been resolved. But a follow-up remained. So I'll repurpose this issue for it.

We need to convert the Annotation used in Drupal\eca_ui\Plugin\modeler_api_model_owner\Eca to use the new Attribute instead of the annotation. Really quick and easy fix.

Changing category accordingly. And I assume that if everything is implemented in both modeler_api and here in ECA, we won't require any BC layer any longer, am I correct?

Fixed this together with 📌 Convert from annotations to attributes Active .