- Issue created by @catch
- π¬π§United Kingdom catch
Moving this under CSS.
This appears to be mainly supported by the 'align' core filter, which could use #attached.
So I wonder whether the align filter, and views once it's using the core classes, could both #attach a core/align library.
Then we'd still need to address the lack of RTL support on top of that too.
- π¬π§United Kingdom darren.fisher
darren.fisher β made their first commit to this issueβs fork.
- Merge request !11627Update align.module.css to use modern CSS logical properties. β (Open) created by darren.fisher
- π¬π§United Kingdom darren.fisher
I've updated the CSS in align.module.css to use modern logical properties. Ideally the class names would also change but that will introduce breaking changes for any themes that use the existing classes. Let me know if there's anything else that needs to happen on this?
- πΊπΈUnited States smustgrave
Should this be postponed on π Remove the views-align-* CSS classes Active
- π¬π§United Kingdom catch
@smustgrave they can happen independently, the other issue doesn't change the CSS file here at all, just remove's views' own version.
- πΊπΈUnited States smustgrave
Ok in that case should this land now? Know there was a comment in the other about combining.
Applied the MR though and text-align right still appears to be working as before so marking RTBC if this should still land before.
- π¬π§United Kingdom catch
Not sure what to do about the classnames though, will at least need another follow-up so back to review for that.