- Issue created by @mondrake
- 🇺🇸United States smustgrave
Seems straight forward and todo issue clearly has already been closed
- 🇳🇿New Zealand quietone
Just a question in the MR to answer. I suspect that the link to the issue can be removed.
- 🇮🇹Italy mondrake 🇮🇹
Well that issue, albeit closed, gives a lot of detail about exactly why the change is needed, IMHO.
- First commit to issue fork.
- 🇨ðŸ‡Switzerland znerol
I agree with #6, issue #2921123: Adjust Rectangle class to calculate rotated image dimensions according to libgd 2.2.2+ → contains valuable research leading to the fix. However, I think we can trust people to use
git blame
to actually find that research (via this issue). I removed the@see
reference. - 🇺🇸United States smustgrave
From the other random ones can a separate MR be opened that runs 1000 times
- 🇨ðŸ‡Switzerland znerol
Repeat test MR is passing. However, there is a fail in
EntityReferenceWidgetTest::testWidgetPreview()
. Is that an instance of a known random test fail?https://git.drupalcode.org/issue/drupal-3514699/-/pipelines/476020/test_...
- 🇺🇸United States smustgrave
Don't see it on https://www.drupal.org/project/drupal/issues/2829040 🌱 [meta] Known intermittent, random, and environment-specific test failures Active maybe needs to be mentioned?
Feedback here appears to be addressed though.