- Issue created by @murz
- Merge request !2Issue #3514365: Add custom Step config and Decimal, Float field types support → (Merged) created by murz
- 🇦🇲Armenia murz Yerevan, Armenia
I added a field to configure the custom step, also support for Decimal and Float field types, please review.
- 🇫🇷France mably
Hi @murz, thanks for your great MR.
Could you fix the small PHPCS warning so we could merge it?
- 🇦🇲Armenia murz Yerevan, Armenia
Fixed the PHP CS and added migration. Also want to make a functional test to ensure that everything works well.
- 🇫🇷France mably
Thanks a lot for the test @murz!
But it looks like it's currently failing though.
Never heard of Nightwatch before. Seems interesting, will have a look at it.
- 🇫🇷France mably
I've been able to run those NightWatch unit tests locally, but they fail like they do on Gitlab-CI.
Been trying to find a solution the whole evening without success... :(
- 🇦🇲Armenia murz Yerevan, Armenia
The test was just not finalized, pushed now the completed version of the test, and seems it's green!
So, now you can review the MR :) - 🇫🇷France mably
Looks like Nightwatch might be replaced by Playwright...
https://www.drupal.org/project/drupal/issues/3467492 📌 Consider dropping Nightwatch in favor of Functional Javascript tests Active